Make sure the first result in most recents is highlighted when user uses CMD+K #52298

nyomanjyotisa · 2024-11-11T03:01:39Z

Explanation of Change

Fixed Issues

$ #51894
PROPOSAL: #51894 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Navigate to search with CMD+K or click on the search icon (only on the Desktop web and Desktop app)
Verify that the top-most result in Recent chats is highlighted
Type in the search bar
Verify that the chat query is highlighted
Close the search bar
Repeat steps 1-2
Click on Enter
Verify that the user navigated to the highlighted Recent chats

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android-Native.mp4

Android: mWeb Chrome

Android-mWeb.Chrome.mp4

iOS: Native

iOS-Native.mp4

iOS: mWeb Safari

iOS-mWeb.Safari.mp4

MacOS: Chrome / Safari

MacOS-Chrome.mp4

MacOS: Desktop

MacOS-Desktop.mp4

…ses CMD+K

nyomanjyotisa · 2024-11-12T10:01:16Z

@Pujan92 should we implement this on mobile native and mweb? or only on large screen(desktop and desktop web)?

Since the enter key hint displayed in the small screen width is "search". And on native mobile clicking search/enter key will always navigate to search page although the search input is empty, instead of navigating to the focused report

2024-11-11.at.10.40.47.mp4

…ocus

melvin-bot · 2024-11-14T14:29:45Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Pujan92 · 2024-11-18T13:09:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2024-11-27.at.18.27.43.mov

MacOS: Desktop

Screen.Recording.2024-11-27.at.18.36.32.mov

Pujan92 · 2024-11-18T13:48:37Z

src/components/Search/SearchRouter/SearchRouter.tsx

+    useEffect(() => {
+        if ((!isWeb && !isDesktop) || textInputValue) {
+            return;
+        }
+        setInitialFocus();
+    }, [setInitialFocus, textInputValue, isWeb, isDesktop]);


Suggested change

useEffect(() => {

if ((!isWeb && !isDesktop) || textInputValue) {

return;

}

setInitialFocus();

}, [setInitialFocus, textInputValue, isWeb, isDesktop]);

useEffect(() => {

if ((!isWeb && !isDesktop)) {

return;

}

setInitialFocus();

}, [setInitialFocus, isWeb, isDesktop]);

Let search change focus be handled by onSearchChange function instead of making call to setInitialFocus twice.

Ah you are right, it calls the setInitialFocus twice

But this is intentional actually, if we dont early return when the textInputValue is not empty, it will trigger the setInitialFocus(); since setInitialFocus updated due to contextualReportData updated when we input search term

See this video

New-Expensify.35.mp4

I think we should remove setInitialFocus(); on onSearchChange instead

As of now we need to focus only for the first time we can remove this entire function and use initiallyFocusedOptionKey as mentioned here. We won't consider of refocusing when the input is cleared by user.

If we use initiallyFocusedOptionKey, it will still focus on all platforms. Don’t we not need to focus on the mobile platform?

New-Expensify.mp4

For that, we can use isLargeScreenWidth and set undefined initiallyFocusedOptionKey based on it.

Pujan92 · 2024-11-18T16:40:17Z

src/components/SelectionList/BaseSelectionList.tsx

            const focusedItem = flattenedSections.allOptions.at(index);
            if (focusedItem) {
                onArrowFocus(focusedItem);
            }
-            (shouldDebounceScrolling ? debouncedScrollToIndex : scrollToIndex)(index, true);
+            if (shouldScrollToIndex) {


Suggested change

if (shouldScrollToIndex) {

if (shouldScrollToFocusedIndex) {

(shouldDebounceScrolling ? debouncedScrollToIndex : scrollToIndex)(index, true);

}

I think we don't need any changes in useArrowKeyFocusManager file.
How about adding state isInitialRender in SearchRouterList with default value false and toggle its value in onLayout of the SelectionList and pass it to SelectionList like below.

shouldScrollToFocusedIndex={!isInitialRender}

Pujan92 · 2024-11-19T14:37:41Z

@nyomanjyotisa I see that the data for different sections is available at different times. I suggest rendering the SelectionList once we fetch all data(sortedRecentSearches, recentReports) from whatever source.
So I propose the below changes, let me know your thoughts.

Render SearchRouterList in SearchRouter component only after fetching all data(add a condition for it).

App/src/components/Search/SearchRouter/SearchRouter.tsx

Line 406 in 03e32f9

<SearchRouterList
In BaseSelectionList component, add a new prop shouldScrollToFocusedIndex with the default value true and use that to avoid scrolling in all places within that component.
In SearchRouterList component,

Add state variable isInitialRender and update it to false in onLayout of SelectionList.
Use initiallyFocusedOptionKey as a consistent solution here

initiallyFocusedOptionKey={styledRecentReports.at(0)?.keyForList}
shouldScrollToFocusedIndex={!isInitialRender}

I believe this is more cleaner solution without modifying common component with more states for the initial focus and I think only for the initial render we should focus the item irrespective of textinput entered and gets cleared by the user.
Let me tag @luacmartins to review the raised PR and my thoughts in this comment.

luacmartins

Left a comment. I also agree with @Pujan92's comments

luacmartins · 2024-11-19T16:38:41Z

src/components/Search/SearchRouter/SearchRouter.tsx

+    const isWeb = getPlatform() === CONST.PLATFORM.WEB;
+    const isDesktop = getPlatform() === CONST.PLATFORM.DESKTOP;


This goes against our best practices - https://github.com/Expensify/App/blob/0dd44ee996d7d2b41ec117205fb52b10a33cf5f0/README.md#platform-specific-file-extensions

@Pujan92 should we create platform-specific files for this case?

nyomanjyotisa · 2024-11-21T06:27:56Z

So I propose the below changes, let me know your thoughts.

Seems good, will work on this today

… all data

nyomanjyotisa · 2024-11-21T09:50:57Z

@Pujan92 have done all your recommendations above, could you check again?

Also, should we create platform-specific files for this case?

src/components/Search/SearchRouter/SearchRouter.tsx

luacmartins · 2024-11-21T19:41:59Z

@nyomanjyotisa why is the conditional !isWeb && !isDesktop? Are we trying to exclude those platforms specifically or just large screen devices in general? Because if it's the latter, we should be using useResponsiveLayout to get the screen width instead and then there's no need to create platform specific files

nyomanjyotisa · 2024-11-22T01:56:11Z

The ⁠isWeb and ⁠isDesktop checks ⁠ are used because this feature only implemented on Desktop Web and Desktop App platform

But yeah I think we should use ⁠isLargeScreenWidth from ⁠ useResponsiveLayout ⁠instead, will fix it

Pujan92 · 2024-11-22T10:22:27Z

@luacmartins I would like to confirm one last thing. I think whenever the search modal opens then only we need to focus first recent item.
Do we need to focus when a user types and clears the search input? Bcoz this scenario doesn't look right to me and leads to unwanted or more conditional code.

I have suggested a solution earlier without refocus but asking to clear it out.

nyomanjyotisa · 2024-11-26T05:05:14Z

PR and recordings updated

luacmartins

LGTM and tests well

Pujan92

@nyomanjyotisa Added cleanup comments as we don't require those changes.

Pujan92 · 2024-11-27T06:04:17Z

src/components/Search/SearchRouter/SearchRouter.tsx

    const [isSearchingForReports] = useOnyx(ONYXKEYS.IS_SEARCHING_FOR_REPORTS, {initWithStoredValues: false});
    const [autocompleteSuggestions, setAutocompleteSuggestions] = useState<AutocompleteItemData[] | undefined>([]);
    const [autocompleteSubstitutions, setAutocompleteSubstitutions] = useState<SubstitutionMap>({});

+    const {isLargeScreenWidth} = useResponsiveLayout();


Suggested change

const {isLargeScreenWidth} = useResponsiveLayout();

Pujan92 · 2024-11-27T06:04:37Z

src/components/Search/SearchRouter/SearchRouter.tsx

+    const setInitialFocus = useCallback(() => {
+        const initialFocusIndex = (sortedRecentSearches?.slice(0, 5).length ?? 0) + (contextualReportData ? 1 : 0);
+        listRef.current?.setFocusedIndex(initialFocusIndex);
+    }, [sortedRecentSearches, contextualReportData]);
+


Suggested change

const setInitialFocus = useCallback(() => {

const initialFocusIndex = (sortedRecentSearches?.slice(0, 5).length ?? 0) + (contextualReportData ? 1 : 0);

listRef.current?.setFocusedIndex(initialFocusIndex);

}, [sortedRecentSearches, contextualReportData]);

Pujan92 · 2024-11-27T06:06:07Z

src/components/Search/SearchRouter/SearchRouter.tsx

+            } else if (!isLargeScreenWidth) {
                listRef.current?.updateAndScrollToFocusedIndex(-1);
+            } else {
+                setInitialFocus();


Suggested change

} else if (!isLargeScreenWidth) {

listRef.current?.updateAndScrollToFocusedIndex(-1);

} else {

setInitialFocus();

} else {

listRef.current?.updateAndScrollToFocusedIndex(-1);

}

Pujan92 · 2024-11-27T06:06:25Z

src/components/Search/SearchRouter/SearchRouterList.tsx

+    useEffect(() => {
+        if (textInputValue) {
+            return;
+        }
+        setIsInitialRender(true);
+    }, [textInputValue]);
+


Suggested change

useEffect(() => {

if (textInputValue) {

return;

}

setIsInitialRender(true);

}, [textInputValue]);

Pujan92 · 2024-11-27T06:07:04Z

src/components/SelectionList/BaseSelectionList.tsx

@@ -716,12 +721,13 @@ function BaseSelectionList<TItem extends ListItem>(
        isTextInputFocusedRef.current = isTextInputFocused;
    }, []);

-    useImperativeHandle(ref, () => ({scrollAndHighlightItem, clearInputAfterSelect, updateAndScrollToFocusedIndex, updateExternalTextInputFocus, scrollToIndex}), [
+    useImperativeHandle(ref, () => ({scrollAndHighlightItem, clearInputAfterSelect, updateAndScrollToFocusedIndex, updateExternalTextInputFocus, scrollToIndex, setFocusedIndex}), [


Suggested change

useImperativeHandle(ref, () => ({scrollAndHighlightItem, clearInputAfterSelect, updateAndScrollToFocusedIndex, updateExternalTextInputFocus, scrollToIndex, setFocusedIndex}), [

useImperativeHandle(ref, () => ({scrollAndHighlightItem, clearInputAfterSelect, updateAndScrollToFocusedIndex, updateExternalTextInputFocus, scrollToIndex}), [

Pujan92 · 2024-11-27T06:17:06Z

@nyomanjyotisa Plz resolves the conflicts.

I think we don't require below test steps.

Clear the search query

Verify that the top-most result in Recent chats is not highlighted

Pujan92 · 2024-11-27T12:59:31Z

All looks good, once you merge main and fix conflicts I will approve.

luacmartins · 2024-11-27T16:46:36Z

We just need to resolve conflicts @nyomanjyotisa

nyomanjyotisa · 2024-11-28T07:05:26Z

Sorry for the delay, the conflicts resolved.
I moved the initiallyFocusedOptionKey to SearchRouter and passed it from SearchRouterList as a prop since the styledRecentReports is moved from SearchRouterList to SearchRouter on the latest main.
Could you check this again? @Pujan92

Pujan92

LGTM, Thanks @nyomanjyotisa and @luacmartins !!

Pujan92 · 2024-11-28T12:25:23Z

src/components/Search/SearchRouter/SearchRouter.tsx

@@ -310,6 +311,10 @@ function SearchRouter({onRouterClose, shouldHideInputCaret}: SearchRouterProps)

    const modalWidth = shouldUseNarrowLayout ? styles.w100 : {width: variables.searchRouterPopoverWidth};

+    const isDataLoaded = useMemo(() => {
+        return (!contextualReportID || contextualReportID !== undefined) && !isLoadingOnyxValue(recentSearchesMetadata) && recentReports.length > 0;


NAB: I think we don't need contextualReportID condition here bcoz currently also that condition truthy for any value.

Suggested change

return (!contextualReportID || contextualReportID !== undefined) && !isLoadingOnyxValue(recentSearchesMetadata) && recentReports.length > 0;

return !isLoadingOnyxValue(recentSearchesMetadata) && recentReports.length > 0;

Why is this a NAB? We should never merge code like this @Pujan92 😒

It shouldn't be NAB, my bad 😢

OSBotify · 2024-11-28T17:54:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-11-30T14:23:35Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.69-1 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

mvtglobally · 2024-12-02T01:49:10Z

failing with original issue on MWeb

Screen_Recording_20241130_184606_Chrome.mp4

mountiny · 2024-12-02T09:49:32Z

@nyomanjyotisa @Pujan92 can you have a look into this?

Pujan92 · 2024-12-02T10:16:57Z

@mvtglobally these changes are specifically for larger screens as mentioned in the test steps and not for the native/mWeb.

github-actions · 2024-12-02T21:34:16Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.69-4 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

nyomanjyotisa added 2 commits November 11, 2024 10:16

Make sure the first result in most recents is highlighted when user u…

de6e681

…ses CMD+K

lint fix

ac997b5

nyomanjyotisa added 4 commits November 14, 2024 21:39

initial focus only for web and desktop, and don't scroll on initial f…

1007716

…ocus

minor fix

f03e1e0

minor fix

dd17a40

minor fix

fe78ba6

nyomanjyotisa marked this pull request as ready for review November 14, 2024 14:29

nyomanjyotisa requested a review from a team as a code owner November 14, 2024 14:29

melvin-bot bot requested review from Pujan92 and removed request for a team November 14, 2024 14:29

Pujan92 suggested changes Nov 18, 2024

View reviewed changes

luacmartins requested changes Nov 19, 2024

View reviewed changes

nyomanjyotisa added 6 commits November 21, 2024 16:17

Render SearchRouterList in SearchRouter component only after fetching…

b86b260

… all data

dont scroll to focused index in initial render search router list

2312a87

minor fix

fd76ed7

minor fix

e502f95

Merge branch 'main' into issue-51894

d3778db

minor fix

913a059

Pujan92 reviewed Nov 21, 2024

View reviewed changes

src/components/Search/SearchRouter/SearchRouter.tsx Show resolved Hide resolved

nyomanjyotisa added 2 commits November 22, 2024 11:50

minor fix

e9bea23

lint fix

a9ab802

lint fix

e4e2ab1

luacmartins reviewed Nov 26, 2024

View reviewed changes

luacmartins previously approved these changes Nov 26, 2024

View reviewed changes

Pujan92 suggested changes Nov 27, 2024

View reviewed changes

minor fix

ef484ce

nyomanjyotisa dismissed luacmartins’s stale review via ef484ce November 27, 2024 07:59

luacmartins self-requested a review November 27, 2024 16:46

luacmartins previously approved these changes Nov 27, 2024

View reviewed changes

Merge branch 'main' into issue-51894

4457266

nyomanjyotisa dismissed luacmartins’s stale review via 4457266 November 28, 2024 06:49

minor fix

ee1acd6

Pujan92 approved these changes Nov 28, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins November 28, 2024 12:18

Pujan92 reviewed Nov 28, 2024

View reviewed changes

luacmartins approved these changes Nov 28, 2024

View reviewed changes

luacmartins merged commit c70b6c1 into Expensify:main Nov 28, 2024
19 checks passed

github-actions bot mentioned this pull request Nov 30, 2024

Deploy Checklist: New Expensify 2024-11-30 #53334

Closed

41 tasks

luacmartins mentioned this pull request Dec 2, 2024

[$250] Android/iOS- Highlighted search result go to search page rather that the highlighted detail page #53401

Open

8 tasks

melvin-bot bot mentioned this pull request Dec 2, 2024

[HOLD for payment 2024-12-09] [$125] Make sure the first result in most recents is highlighted when user uses CMD+K #51894

Closed

		const isWeb = getPlatform() === CONST.PLATFORM.WEB;
		const isDesktop = getPlatform() === CONST.PLATFORM.DESKTOP;

	useImperativeHandle(ref, () => ({scrollAndHighlightItem, clearInputAfterSelect, updateAndScrollToFocusedIndex, updateExternalTextInputFocus, scrollToIndex, setFocusedIndex}), [
	useImperativeHandle(ref, () => ({scrollAndHighlightItem, clearInputAfterSelect, updateAndScrollToFocusedIndex, updateExternalTextInputFocus, scrollToIndex}), [

	return (!contextualReportID \|\| contextualReportID !== undefined) && !isLoadingOnyxValue(recentSearchesMetadata) && recentReports.length > 0;
	return !isLoadingOnyxValue(recentSearchesMetadata) && recentReports.length > 0;

Make sure the first result in most recents is highlighted when user uses CMD+K #52298

Make sure the first result in most recents is highlighted when user uses CMD+K #52298

Conversation

nyomanjyotisa commented Nov 11, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

nyomanjyotisa commented Nov 12, 2024

melvin-bot bot commented Nov 14, 2024

Pujan92 commented Nov 18, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nyomanjyotisa Nov 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pujan92 commented Nov 19, 2024

luacmartins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nyomanjyotisa commented Nov 21, 2024

nyomanjyotisa commented Nov 21, 2024

luacmartins commented Nov 21, 2024

nyomanjyotisa commented Nov 22, 2024 • edited Loading

Pujan92 commented Nov 22, 2024 • edited Loading

nyomanjyotisa commented Nov 26, 2024

luacmartins left a comment

Choose a reason for hiding this comment

Pujan92 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pujan92 commented Nov 27, 2024

Pujan92 commented Nov 27, 2024

luacmartins commented Nov 27, 2024

nyomanjyotisa commented Nov 28, 2024

Pujan92 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Nov 28, 2024

github-actions bot commented Nov 30, 2024

mvtglobally commented Dec 2, 2024

mountiny commented Dec 2, 2024

Pujan92 commented Dec 2, 2024

github-actions bot commented Dec 2, 2024

nyomanjyotisa commented Nov 11, 2024 •

edited

Loading

Pujan92 commented Nov 18, 2024 •

edited

Loading

nyomanjyotisa Nov 22, 2024 •

edited

Loading

nyomanjyotisa commented Nov 22, 2024 •

edited

Loading

Pujan92 commented Nov 22, 2024 •

edited

Loading

Pujan92 left a comment •

edited

Loading